srctree

Robin Linden parent f1b6b05d f39f5b2e
meta: Enable clang-tidy's check for inconsistent parameter names

inlinesplit
.clang-tidy added: 7, removed: 6, total 1
@@ -45,6 +45,7 @@ Checks: >
misc-*,
modernize-*,
readability-identifier-naming,
readability-inconsistent-declaration-parameter-name,
readability-qualified-auto,
-bugprone-exception-escape,
-bugprone-narrowing-conversions,
 
browser/gui/app.cpp added: 7, removed: 6, total 1
@@ -379,13 +379,13 @@ void App::on_layout_updated() {
layout_str_ = layout != nullptr ? layout::to_string(*layout) : "";
}
 
std::vector<dom::Node const *> App::get_hovered_nodes(geom::Position p) const {
std::vector<dom::Node const *> App::get_hovered_nodes(geom::Position document_position) const {
auto const *layout = engine_.layout();
if (!page_loaded_ || layout == nullptr) {
return {};
}
 
auto const *moused_over = layout::box_at_position(*layout, p);
auto const *moused_over = layout::box_at_position(*layout, document_position);
if (moused_over == nullptr || moused_over->node == nullptr) {
return {};
}
 
dom/dom.h added: 7, removed: 6, total 1
@@ -129,7 +129,7 @@ inline std::vector<T const *> nodes_by_xpath(T const &root, std::string_view xpa
return goal_nodes;
}
 
std::string to_string(Document const &node);
std::string to_string(Document const &);
 
} // namespace dom