srctree

Robin Linden parent 8489504a d4b56608
all: Simplify finding if a string contains another string

browser/gui/app.cpp added: 7, removed: 9, total 0

@@ -49,7 +49,7 @@ std::optional<std::string_view> try_get_text_content(dom::Document const &doc, s

}

void ensure_has_scheme(std::string &url) {

if (url.find("://") == std::string::npos) {

if (!url.contains("://")) {

spdlog::info("Url missing scheme, assuming https");

url = fmt::format("https://{}", url);

}

css/parser.h added: 7, removed: 9, total 0

@@ -412,7 +412,7 @@ private:

} else if (maybe_font_style->starts_with("oblique")) {

font_style = *maybe_font_style;

if (auto maybe_angle = tokenizer.peek()) {

if (maybe_angle->find("deg") != std::string_view::npos) {

if (maybe_angle->contains("deg")) {

font_style += ' ';

font_style += *maybe_angle;

tokenizer.next();

css/parser_test.cpp added: 7, removed: 9, total 0

@@ -829,10 +829,8 @@ int main() {

// Very incorrect.

auto const &src = rules[0].declarations.at(css::PropertyId::Unknown);

auto woff2 = src.find(R"(url("/fonts/OpenSans-Regular-webfont.woff2") format("woff2"))");

expect(woff2 != std::string::npos);

auto woff = src.find(R"(url("/fonts/OpenSans-Regular-webfont.woff") format("woff")");

expect(woff != std::string::npos);

expect(src.contains(R"(url("/fonts/OpenSans-Regular-webfont.woff2") format("woff2"))"));

expect(src.contains(R"(url("/fonts/OpenSans-Regular-webfont.woff") format("woff")"));

});

return etest::run_all_tests();