srctree

Robin Linden parent 63358146 bbd51375
meta: Re-enable clang-tidy's NewDeleteLeaks check

The false positives we had when running clang-tidy-14 appear to beresolved now.

inlinesplit
.clang-tidy added: 1, removed: 8, total 0
@@ -10,12 +10,6 @@
# -cert-dcl21-cpp: Deprecated, will be removed in clang-tidy 19.
# https://clang.llvm.org/extra/clang-tidy/checks/cert/dcl21-cpp.html
#
# -clang-analyzer-cplusplus.NewDeleteLeaks: Lots of false positives w/
# -std=c++2b when calling std::make_shared in the JS AST.
# js/ast_executor_test.cpp:176:5: error: Potential leak of memory pointed to by
# field '_M_pi' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
# Very similar call stack to https://github.com/llvm/llvm-project/issues/55219
#
# -clang-diagnostic-builtin-macro-redefined: Bazel redefines a lot of builtin
# macros to set up a reproducible build.
#
@@ -50,7 +44,6 @@ Checks: >
-bugprone-narrowing-conversions,
-bugprone-unchecked-optional-access,
-cert-dcl21-cpp,
-clang-analyzer-cplusplus.NewDeleteLeaks,
-clang-diagnostic-builtin-macro-redefined,
-google-build-using-namespace,
-misc-const-correctness,