srctree

Robin Linden parent 461d5c06 2ae8f78a
net: Nodiscard Socket::connect's return value

inline split

net/socket.cpp added: 9, removed: 9, total 0

@@ -28,7 +28,7 @@ namespace net {

namespace {

struct BaseSocketImpl {

bool connect(asio::ip::tcp::resolver &resolver,

[[nodiscard]] bool connect(asio::ip::tcp::resolver &resolver,

asio::ip::tcp::socket &socket,

std::string_view host,

std::string_view service) {

net/socket.h added: 9, removed: 9, total 0

@@ -20,7 +20,7 @@ public:

Socket(Socket &&) noexcept;

Socket &operator=(Socket &&) noexcept;

bool connect(std::string_view host, std::string_view service);

[[nodiscard]] bool connect(std::string_view host, std::string_view service);

std::size_t write(std::string_view data);

std::string read_all();

std::string read_until(std::string_view delimiter);

@@ -39,7 +39,7 @@ public:

SecureSocket(SecureSocket &&) noexcept;

SecureSocket &operator=(SecureSocket &&) noexcept;

bool connect(std::string_view host, std::string_view service);

[[nodiscard]] bool connect(std::string_view host, std::string_view service);

std::size_t write(std::string_view data);

std::string read_all();

std::string read_until(std::string_view delimiter);

net/socket_test.cpp added: 9, removed: 9, total 0

@@ -54,7 +54,7 @@ int main() {

s.add_test("Socket::read_all", [](etest::IActions &a) {

auto server = Server{"hello!"};

net::Socket sock;

sock.connect("localhost", std::to_string(server.port()));

a.require(sock.connect("localhost", std::to_string(server.port())));

a.expect_eq(sock.read_all(), "hello!");

});

@@ -62,7 +62,7 @@ int main() {

s.add_test("Socket::read_until", [](etest::IActions &a) {

auto server = Server{"beep\r\nbeep\r\nboop\r\n"};

net::Socket sock;

sock.connect("localhost", std::to_string(server.port()));

a.require(sock.connect("localhost", std::to_string(server.port())));

a.expect_eq(sock.read_until("\r\n"), "beep\r\n");

@@ -72,7 +72,7 @@ int main() {

s.add_test("Socket::read_bytes", [](etest::IActions &a) {

auto server = Server{"123456789"};

net::Socket sock;

sock.connect("localhost", std::to_string(server.port()));

a.require(sock.connect("localhost", std::to_string(server.port())));

a.expect_eq(sock.read_bytes(3), "123");

a.expect_eq(sock.read_bytes(2), "45");